On 16 August 2017 at 07:40, Michel Dänzer <mic...@daenzer.net> wrote:
> From: Michel Dänzer <michel.daen...@amd.com>
>
> https://bugs.llvm.org/show_bug.cgi?id=6823 still affects current LLVM.
> llvm-config --libs only reports the single shared library if LLVM was
> built with -DLLVM_LINK_LLVM_DYLIB=ON. llvm-config --shared-mode reports
> "shared" in that case, "static" otherwise (even if LLVM was built with
> -DLLVM_BUILD_LLVM_DYLIB=ON).
>
I think your summary nicely covers why I am so hesitant about changing
anything around LLVM detection :-(
Regardless, thanks for making things more robust!
> v2: Keep the LLVM < 4.0 test. (llvm-config --shared-mode is actually
> available since LLVM 3.8, but that would make the test too
> complicated :)
>
> Fixes: 3d8da1f678e1 ("configure: Trust LLVM >= 4.0 llvm-config --libs
> for shared libraries")
> Tested-by: Dieter Nützel <die...@nuetzel-hh.de> # v1
> Signed-off-by: Michel Dänzer <michel.daen...@amd.com>
Patch works on my end and seems correct.
Reviewed-by: Emil Velikov <emil.veli...@collabora.com>
-Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
