On 25 August 2017 at 23:25, Jason Ekstrand <ja...@jlekstrand.net> wrote: > On Fri, Aug 25, 2017 at 1:20 PM, Emil Velikov <emil.l.veli...@gmail.com> > wrote: >> >> From: Emil Velikov <emil.veli...@collabora.com> >> >> Originally required for the u_vector implementation, which was inlined >> in u_vector.h with previous commit. >> >> Using libmesautil pulled the C++ runtime (string_to_uint_map.cpp), >> which is something don't want to impose in our libEGL. >> >> We could consider rewriting string_to_uint_map in C, but that's too >> invasive for a stable fix. > > > A quick grep and it looks like the only users of string_to_uint_map are > src/compiler/glsl and src/mesa which depends on src/compiler/glsl. Why not > just move string_to_uint_map into src/compiler/glsl or src/compiler until > such a time as we actually have another user. Don't get me wrong, I think > string_to_uint_map is useful but I think the better option here is to > disallow C++ in src/util. > Great idea, thanks. I'm build testing for subtle breakages and will send a patch in a couple of minutes.
-Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
