Am 30.09.2017 um 12:57 schrieb Benedikt Schemmer:
It should be handled as an error if resource_formats[0] is PIPE_FORMAT_NONE.
Better write this as:
if (resource_formats[i] == PIPE_FORMAT_NONE) {
if (i == 0)
gotot error;
continue;
}
...
I dont think it can be zero.
In the beginning of vl_video_buffer.c formats and return values are defined and
resource_formats[0] is guranteed to not
be PIPE_FORMAT_NONE. The only other return value is null which caught
immediately after requesting resource_formats
(line 59, in si_uvd.c).
So maybe
assert(resource_formats[0] == PIPE_FORMAT_NONE)
for debugging purposes?
Yeah, that works for me as well.
General idea is that the code should somehow fail gracefully if we see
an format not supported as a template.
Regards,
Christian.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
