On Wed 02 May 2018, Miguel Casas wrote:
> This patch adds {X,A}BGR2101010 entries to the list of supported
> |intel_image_formats|.
>
> BUG=https://crbug.com/776093
> TEST=Compile and deploy mesa this patch, then playback
> a VP9 Profile 2 video with sw decoder using crrev.com/c/897894.
> ---
> src/mesa/drivers/dri/i965/intel_screen.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Everything I said about the previous patch applies here too :)
Also, two new comments:
* Don't add |bars| around token names. If you use annotate the token
name, then use 'single_quotes'. Sometimes people use `backticks` too.
It's also fine to omit the annotation.
* In brace expansion, spaces are preserved. Therefore, it should be
{X,A} and not {X, A}.
By the way, most people would squash these two patches together and use
the prefix "i965:" or "i965,dri:". Me, I prefer to keep them separate.
It's your call.
When you resend the patch (or patches), CC Kenneth Graunke too.
>
> diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
> b/src/mesa/drivers/dri/i965/intel_screen.c
> index 409f763b64..d3488b9f29 100644
> --- a/src/mesa/drivers/dri/i965/intel_screen.c
> +++ b/src/mesa/drivers/dri/i965/intel_screen.c
> @@ -190,6 +190,12 @@ static const struct intel_image_format
> intel_image_formats[] = {
> { __DRI_IMAGE_FOURCC_XRGB2101010, __DRI_IMAGE_COMPONENTS_RGB, 1,
> { { 0, 0, 0, __DRI_IMAGE_FORMAT_XRGB2101010, 4 } } },
>
> + { __DRI_IMAGE_FOURCC_ABGR2101010, __DRI_IMAGE_COMPONENTS_RGBA, 1,
> + { { 0, 0, 0, __DRI_IMAGE_FORMAT_ABGR2101010, 4 } } },
> +
> + { __DRI_IMAGE_FOURCC_XBGR2101010, __DRI_IMAGE_COMPONENTS_RGB, 1,
> + { { 0, 0, 0, __DRI_IMAGE_FORMAT_XBGR2101010, 4 } } },
> +
> { __DRI_IMAGE_FOURCC_ARGB8888, __DRI_IMAGE_COMPONENTS_RGBA, 1,
> { { 0, 0, 0, __DRI_IMAGE_FORMAT_ARGB8888, 4 } } },
>
> --
> 2.17.0.441.gb46fe60e1d-goog
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
