Hi Chad, On Wed, Jul 25, 2018 at 10:11 AM Chad Versace <chadvers...@chromium.org> wrote: > > Problem 1: u_debug_stack_android.cpp transitively included > "pipe/p_compiler.h", but src/gallium/include was missing from the C++ > include path. > > Problem 2: Add -std=c++11 to AM_CXXFLAGS. Android's libbacktrace headers > require C++11, but the Android toolchain (at least in the Chrome OS SDK) > does not enable C++11 by default. > > v2: Add -std=c++11. > > Cc: Gurchetan Singh <gurchetansi...@chromium.org> > Cc: Eric Engestrom <eric.engest...@intel.com> > --- > src/gallium/auxiliary/Makefile.am | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/Makefile.am > b/src/gallium/auxiliary/Makefile.am > index 03908198772..4bfa7648389 100644 > --- a/src/gallium/auxiliary/Makefile.am > +++ b/src/gallium/auxiliary/Makefile.am > @@ -13,6 +13,7 @@ AM_CFLAGS = \ > $(MSVC2013_COMPAT_CFLAGS) > > AM_CXXFLAGS = \ > + $(GALLIUM_CFLAGS) \ > $(VISIBILITY_CXXFLAGS) \ > $(MSVC2013_COMPAT_CXXFLAGS) > > @@ -22,6 +23,10 @@ libgallium_la_SOURCES = \ > $(GENERATED_SOURCES) > > if HAVE_PLATFORM_ANDROID > +# Android's libbacktrace headers required C++11, but the Android toolchain > (at > +# least in the Chrome OS SDK) does not enable C++11 by default. > +AM_CXXFLAGS += $(CXX11_CXXFLAGS) > +
This is something that would normally be handled by the .pc file for given library. Package build system shouldn't be polluted with such system-specific low level dependencies. Best regards, Tomasz _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev