Yep. It's better to just use C99 bool everywhere. Jose
On 30/06/2019 06:00, Marek Olšák wrote: > boolean predates c99 support in MSVC. I think there is no reason for > boolean in gallium now. > > Marek > > On Sat., Jun. 29, 2019, 00:09 Ilia Mirkin, <imir...@alum.mit.edu > <mailto:imir...@alum.mit.edu>> wrote: > > Ken pointed out on IRC today that there was still a lot of "boolean" > (vs bool/_Bool) usage in gallium. In fact, many interfaces are > specified with boolean. > > I had it in my mind that I had at some point removed most boolean > usage, but that is just not the case - first of all, the interfaces > remain with it, and I could find no evidence of such a commit. I must > have imagined it. > > Is there any reason to keep boolean around? I know conversions must be > done carefully (since incorrect-but-working usage would not currently > be caught by the compiler), but are there any practical reasons to > avoid C99 _Bool in gallium code? > > If not, I may begin converting things over. > > Cheers, > > -ilia > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org <mailto:mesa-dev@lists.freedesktop.org> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-dev&data=02%7C01%7Cjfonseca%40vmware.com%7C513e439c4dbe42d80f8808d6fd17f8f1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636974676763464482&sdata=sT8rkOoZOZq4tK2lZ1U7QpMtbDR7qb4BGYejtEBa1AQ%3D&reserved=0> > > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-dev&data=02%7C01%7Cjfonseca%40vmware.com%7C513e439c4dbe42d80f8808d6fd17f8f1%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636974676763494464&sdata=PudvVZvCoB3oP58vHYwF%2Bq3y14psK3z%2F7PUfayMpidI%3D&reserved=0 > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
