Patch 1 is reviewed-by. Patch 2 I commented on for a v2.
Patch 3 and 4 will be reviewed-by once they're updated with the patch 2 rename (merge conflicts). On Fri, Aug 30, 2019 at 04:05:33PM +0200, Boris Brezillon wrote: > Hello, > > I'm currently reworking the job flushing logic to allow and I noticed > a few things in the existing that could be addressed independently. > > Patch 1 is addressing a TODO, though the additional panfrost_job_add_bo() > is probably only needed for debug purpose (there's no risk of > use-after-free here). > > Patch 2 is something Alyssa had in her TODO list, and I thought it'd > be wise to do it now to avoid misnaming new fields/functions while > reworking the batch dependency/flushing logic. > > Patch 3 is about making function prototype consistent with the > function name, and patch 4 is about shrinking the number of args passed > to some functions when information can be retrieved from other args. > > Regards, > > Boris > > Boris Brezillon (4): > panfrost: Add transient BOs to job batches > panfrost: s/job/batch/ > panfrost: Pass a batch to panfrost_drm_submit_vs_fs_batch() > panfrost: Stop passing a ctx to functions being passed a batch > > src/gallium/drivers/panfrost/pan_allocate.c | 4 +- > src/gallium/drivers/panfrost/pan_blend_cso.c | 4 +- > src/gallium/drivers/panfrost/pan_compute.c | 2 +- > src/gallium/drivers/panfrost/pan_context.c | 50 ++--- > src/gallium/drivers/panfrost/pan_context.h | 10 +- > src/gallium/drivers/panfrost/pan_drm.c | 35 ++-- > src/gallium/drivers/panfrost/pan_fragment.c | 18 +- > src/gallium/drivers/panfrost/pan_instancing.c | 4 +- > src/gallium/drivers/panfrost/pan_job.c | 182 +++++++++--------- > src/gallium/drivers/panfrost/pan_job.h | 53 +++-- > src/gallium/drivers/panfrost/pan_mfbd.c | 30 +-- > src/gallium/drivers/panfrost/pan_resource.c | 4 +- > src/gallium/drivers/panfrost/pan_scoreboard.c | 20 +- > src/gallium/drivers/panfrost/pan_screen.c | 2 +- > src/gallium/drivers/panfrost/pan_screen.h | 6 +- > src/gallium/drivers/panfrost/pan_sfbd.c | 36 ++-- > src/gallium/drivers/panfrost/pan_varyings.c | 2 +- > 17 files changed, 234 insertions(+), 228 deletions(-) > > -- > 2.21.0 >
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev