On Thu, Mar 14, 2013 at 10:01:00PM -0500, Aaron Watry wrote: > This series depends on the one-off patch I just sent to add max(). > > 1) Fix the broken abs_diff integer built-in. > 2) Add clamp for both integer and floating types in a new shared/ dir in order > to reduce code duplication and improve maintainability. > 3) Move the max() function into the shared/ directory.
This series looks good and actually negates my comment on the max patch. I think we should make sure we have piglit tests that cover the NAN and INF cases, because I'm not sure we handle those correctly in the backend. For the series: Reviewed-by: Tom Stellard <thomas.stell...@amd.com> > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
