On Mon, May 06, 2013 at 07:35:42PM -0500, Aaron Watry wrote: > These two patches fix a number of piglit OpenCL test failures on my > HD6850 (Barts). > > There are no piglit CL test regressions and the llvm make check runs > without any unexpected failures. >
Hi Aaron, These patches look good to me, but you should also add some lit tests for these opcodes. For R600, the tests are located in test/CodeGen/R600. A good example to look at is the srl.ll test, the sra.ll test should be more or less the same. fcmp-cnd.ll would be a good example for the vselect.ll test as a vector version of it should generate vselect nodes (though you'll want to make sure to use i32 types instead of floats). -Tom _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev