On Friday, March 20, 2015 02:36:15 PM Jason Ekstrand wrote: > On Fri, Mar 20, 2015 at 2:28 PM, Ian Romanick <i...@freedesktop.org> wrote: > > On 03/20/2015 02:26 PM, Jason Ekstrand wrote: > >> On Fri, Mar 20, 2015 at 2:24 PM, Ian Romanick <i...@freedesktop.org> wrote: > >>> On 03/20/2015 11:24 AM, Jason Ekstrand wrote: > >>>> --- > >>>> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 3 +-- > >>>> 1 file changed, 1 insertion(+), 2 deletions(-) > >>>> > >>>> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > >>>> b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > >>>> index 5d88fe7..a059dbb 100644 > >>>> --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > >>>> +++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > >>>> @@ -1243,8 +1243,7 @@ fs_visitor::nir_emit_alu(nir_alu_instr *instr) > >>>> break; > >>>> > >>>> case nir_op_flrp: > >>>> - /* TODO emulate for gen < 6 */ > >>>> - inst = emit(LRP(result, op[2], op[1], op[0])); > >>>> + inst = emit_lrp(result, op[0], op[1], op[2]); > >>>> inst->saturate = instr->dest.saturate; > >>> > >>> I wouldn't mind if you made this follow the pattern we use many other > >>> places: > >>> > >>> emit_lrp(result, op[0], op[1], op[2]) > >>> ->saturate = instr->dest.saturate; > >>> > >>> unless inst is used later. > >> > >> I did that for *everything* in the initial NIR -> FS pass and Ken made > >> me take it out. > > > > Hmm... he might complain about some of the patches I just sent out, > > then. I thought this was the "cool new way." > > So did I... But then I got to go through a file and take out 20 or 30 of them.
It's definitely not the prevaling style; "cool new way" is fairly apt. I think Curro started doing this a while back. I think someone else preferred the 'inst' temporary, but I don't recall who (maybe Eric?). Honestly, at this point, it doesn't bother me. If you guys like that style, and prefer doing it that way, that's fine with me.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
