Bugs item #1931487, was opened at 2008-04-01 11:20 Message generated for change (Settings changed) made by bindul You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1020092&aid=1931487&group_id=212019
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: insight-ui Group: insight-ui-v1.5.1 >Status: Closed Resolution: Fixed Priority: 6 Private: No Submitted By: Bindul Bhowmik (bindul) Assigned to: Bindul Bhowmik (bindul) Summary: Remote Receiver does not stop Initial Comment: The Insight Remote Protocol Receiver once started does not stop if events are already loaded in the application from a local file. The receiver starts and stops fine when no events are loaded. ---------------------------------------------------------------------- Comment By: Bindul Bhowmik (bindul) Date: 2008-04-04 01:19 Message: Logged In: YES user_id=1127769 Originator: YES Fixed with a workaround. The StopReceiverAction now stops both a tailing file action as well as a Remote receiver. There is no if else, it tries to call stop on both receivers. Fix committed on the insight-ui-1.5.0 branch in Revision 160. Should be available in 1.5.2 release. ---------------------------------------------------------------------- Comment By: Bindul Bhowmik (bindul) Date: 2008-04-01 16:46 Message: Logged In: YES user_id=1127769 Originator: YES Regu, Need your input on this. I found out the problem. It is in the StopReceiverAction (http://mindtreeinsight.svn.sourceforge.net/viewvc/mindtreeinsight/insight/insight-ui/branches/insight-ui-1.5.0/src/main/java/com/mindtree/techworks/insight/gui/action/StopReceiverAction.java?view=markup#l_76). The method first tries to look at the LoadLocalFileAction and if that instance does not have a receiver instance in it, then looks at the RemoteProtocolReceiverAction. If a file has already been loaded from the local file system, there will be a receiver instance in the Local File Action; hence the stop is never called on the Remote Protocol Receiver Action. Thinking about it, it is a general Insight design that receivers are never cleared from the Actions (which are singletons). My quick and dirty take to fix this defect is to have a new action to stop the remote receiver. We can take a good look at this defect (maybe open a feature req.) and look at redesigning the whole Receiver and Action interaction when we do 2.0. Bindul ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1020092&aid=1931487&group_id=212019 ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Register now and save $200. Hurry, offer ends at 11:59 p.m., Monday, April 7! Use priority code J8TLD2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ mindtreeinsight-devel mailing list mindtreeinsight-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mindtreeinsight-devel
