> A question on code formatting: Are there guidelines for Mixxx?
http://www.mixxx.org/wiki/doku.php/coding_guidelines
2015-01-28 0:58 GMT+01:00 RJ Ryan <rr...@mixxx.org>:
> Hm, are these mostly in library code (lib/vamp-plugins)? Do you have some
> examples in our tree?
>
> On Tue, Jan 27, 2015 at 3:53 PM, Nico Schlömer <nico.schloe...@gmail.com>
> wrote:
>
>> Many of the suggested fixes concern the funny construct
>> ```
>> if (_id < 0)
>> return _id;
>>
>> return _id;
>> ```
>> suggesting to replace it by the simpler
>> ```
>> return _id;
>> ```
>> Anything that speaks against this?
>>
>> Cheers,
>> Nico
>>
>> On Wed, Jan 28, 2015 at 12:50 AM, RJ Ryan <rr...@mixxx.org> wrote:
>> > Neat -- thanks for running it.
>> >
>> > I'll bet the bugs per kLOC is low because of our massive amounts of XML
>> and
>> > JS -- I wonder if that counts in the denominator? Also the compiled
>> > translation (.ts) files confuse GitHub (it thinks they're TypeScript) so
>> > that could also be a factor. I don't think we have 400kLOC of C++.
>> >
>> > $ wc -l src/**/**.(h|cpp)
>> > 162731 total
>> > $ wc -l (src|plugins|vamp-plugins)/**/**.(h|cpp)
>> > 224211 total
>> >
>> > Shrug -- it'll be nice to get those fixes in either way.
>> >
>> > Cheers,
>> > RJ
>> >
>> > On Tue, Jan 27, 2015 at 3:27 PM, Nico Schlömer <
>> nico.schloe...@gmail.com>
>> > wrote:
>> >>
>> >> Hi all,
>> >>
>> >> The first results from coverity are rolling in [1] and little to my
>> >> surprise, the code quality of Mixxx allows for as few as 0.46 bugs per
>> >> 1000 loc. This is significantly below the average number of defects of
>> >> software projects of comparable size. Congratulations on this!
>> >>
>> >> Feel free to sign up for access to [1] (all info is private by default
>> >> for security reasons) and you'll be able see the details.
>> >>
>> >> I'm currently preparing a pull request for the few high-impact bugs
>> >> that slipped through.
>> >>
>> >> A question on code formatting: Are there guidelines for Mixxx? I'm
>> >> seeing a lot of trailing whitespace, inconsistent use of tabs and
>> >> spaces, even DOS-carriage returns.
>> >>
>> >> Cheers,
>> >> Nico
>> >>
>> >>
>> >> [1] https://scan.coverity.com/projects/4023
>> >>
>> >>
>> >>
>> ------------------------------------------------------------------------------
>> >> Dive into the World of Parallel Programming. The Go Parallel Website,
>> >> sponsored by Intel and developed in partnership with Slashdot Media, is
>> >> your
>> >> hub for all things parallel software development, from weekly thought
>> >> leadership blogs to news, videos, case studies, tutorials and more.
>> Take a
>> >> look and join the conversation now. http://goparallel.sourceforge.net/
>> >> _______________________________________________
>> >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> >> http://mixxx.org
>> >>
>> >>
>> >> Mixxx-devel mailing list
>> >> Mixxx-devel@lists.sourceforge.net
>> >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>> >
>> >
>>
>
>
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming. The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is
> your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net/
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
