Good news everyone - I'm actually on the right friggin' branch now! Bad new
is that, no, SoundSourceMediaFoundation.cpp does not currently compile on
Windows.
So the couple of bugs I've reported are actually against the master branch.
It will be interesting to see if the new branch fixes them.
Here are the compile errors. I will try to fix them this weekend if no one
beats me to it.
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(251) :
error C
2664: 'void SoundSourceMediaFoundation::copyFrames(CSAMPLE *,size_t *,const
CSAM
PLE *,size_t)' : cannot convert argument 2 from 'SINT *' to 'size_t *'
Types pointed to are unrelated; conversion requires
reinterpret_cast, C-
style cast or function-style cast
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(393) :
error C
2664: 'void SoundSourceMediaFoundation::copyFrames(CSAMPLE *,size_t *,const
CSAM
PLE *,size_t)' : cannot convert argument 2 from 'SINT *' to 'size_t *'
Types pointed to are unrelated; conversion requires
reinterpret_cast, C-
style cast or function-style cast
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(580) :
error C
2065: 'kNumChannels' : undeclared identifier
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(584) :
error C
2065: 'kNumChannels' : undeclared identifier
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(584) :
error C
2660: 'memmove' : function does not take 2 arguments
plugins\soundsourcemediafoundation\soundsourcemediafoundation.cpp(588) :
error C
2065: 'kNumChannels' : undeclared identifier
On Thu, Apr 16, 2015 at 2:14 AM, Uwe Klotz <uwe_kl...@web.de> wrote:
> Thank you for your tests, Ryan! Since the old build server has been shut
> down I never got any feedback about my modifications on other platforms
> than Linux.
>
> SoundSourceSndFile is responsible for decoding WAV files. The file is
> analyzed correctly and plays without any issues on Fedora 21 x86_64 with
> libsndfile 1.0.25 installed.
>
> Playing AAC/M4A files through the SoundSourceMediaFoundation plugin would
> be an additional test especially for Windows. I wonder if this class still
> compiles? The same applies to SoundSourceCoreAudio on OS X. Any feedback
> would be greatly appreciated!
>
> Uwe
>
>
> On 04/16/2015 03:11 AM, Ryan Kramer wrote:
>
> I've found 2 potential issues while testing this branch on Windows.
>
> 1) Other media players can play this file:
> http://www.kozco.com/tech/organfinale.wav (linked from
> http://www.kozco.com/tech/soundtests.html) Mixxx will load and analyze
> this file but playback is silent. The waveform is empty also, as you would
> expect from a silent track. Note that this also happens with the master
> branch of Mixxx.
>
> 2) I ran auto-DJ for 16+ hours and then tried to close Mixxx, but it
> hung (for at least an hour before I noticed and killed it). The last
> message in the debug output was either "Deleting HSS1394 devices" or
> "Deleting HID devices". I guess I should have written it down. The gdb did
> not give me a backtrace so I will have to figure that out before I try to
> reproduce it. I don't know if this one also happens in the master branch.
>
> On Tue, Apr 14, 2015 at 2:09 AM, Daniel Schürmann <dasch...@mixxx.org>
> wrote:
>
>> Hi,
>>
>> Who has a Mac build environment and some spare time to run similar test?
>> Thank you!
>>
>> Daniel
>>
>>
>>
>> 2015-04-14 8:56 GMT+02:00 Daniel Schürmann <dasch...@mixxx.org>:
>>
>>> Hi Ryan,
>>>
>>> cool, thank you very much.
>>>
>>> The new features an fixes provided by the branch are roughly: (@Uwe
>>> please correct me)
>>>
>>> * floating point sample interface
>>> * no clamping to 1.0 after decoding
>>> * Better stream error handling
>>> * high resolution mp3 decoding (32 bit fixed point)
>>> * Better tagging issue handling
>>>
>>> The branch offers some new unit test. You should run them first
>>> (mixxx-test.exe)
>>> It is probably the best to find you own test cases, to have finally a
>>> good overall test coverage.
>>>
>>> The seek error effects only some VBR mp3 files. You can test it by
>>> jumping forward and backward to the file and check if the
>>> Waveform allays matches the sound output.
>>>
>>> My test on Linux was like that:
>>> * create a new library (rename mixxxdb.sqlite)
>>> * Start Mixxx in a debugger
>>> * Mass analyse all tracks
>>> * Play AutoDJ in random mode
>>> * Watch out for crashes, sound distortion and tagging issues.
>>>
>>> This runs very long and with only some result results. After two days,
>>> I have stopped that and tested only
>>> abnormal mp3s found in my collection by an mp3 checking tool.
>>> I have actually found some files where Mixxx 1.11 plays the embedded
>>> picture where Uwes Branch just reject the faulty file.
>>>
>>> Finally I have tested some files found on the web of the formats that
>>> are supported by Mixxx but not in my library.
>>>
>>> Kind regards,
>>>
>>> Daniel
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> 2015-04-14 4:55 GMT+02:00 Ryan Kramer <default.kra...@gmail.com>:
>>>
>>>> I can build on Windows and probably test the branch, depending on what
>>>> is meant by "test the branch". If it's just running auto-DJ for a few days
>>>> I can do that, although my audio collection is very homogeneous - almost
>>>> all mp3s, mostly from Amazon and a few from Traxsource. If someone could
>>>> provide more details and/or audio files I think I could test more
>>>> effectively. Let me know.
>>>>
>>>> - Kramer
>>>>
>>>> On Mon, Apr 13, 2015 at 12:56 PM, Nico Schlömer <
>>>> nico.schloe...@gmail.com> wrote:
>>>>
>>>>> OS X seems to be (partly) supported by Travis [1].
>>>>>
>>>>> –Nico
>>>>>
>>>>>
>>>>> [1] http://docs.travis-ci.com/user/multi-os/
>>>>>
>>>>> On Sun, Apr 12, 2015 at 11:48 PM, Daniel Schürmann <dasch...@mixxx.org>
>>>>> wrote:
>>>>> > Hi,
>>>>> >
>>>>> > I have started to test the new branch on my Atom Netbook as a Linux
>>>>> 32
>>>>> > bit low end reference.
>>>>> > I have created a new sqlight library, analyzed my whole external Hdd
>>>>> and
>>>>> > play AutoDJ tracks in library random mode.
>>>>> > The Library contains mp3, m4a and some wave files.
>>>>> > It is running since two days, without any crashes.
>>>>> >
>>>>> > I have some minor findings that are also issues of the master build:
>>>>> > https://bugs.launchpad.net/mixxx/+bug/1398704 AutoDj hangs if track
>>>>> is
>>>>> > shorter than transition time
>>>>> > https://bugs.launchpad.net/mixxx/+bug/1442905 Analysis prograss bar
>>>>> is
>>>>> > jumping ..
>>>>> > https://bugs.launchpad.net/mixxx/+bug/1443181 continue mass analysis
>>>>> >
>>>>> > I have also some tacks that are refused from the new branch with a
>>>>> > pop-up window that they could not be loaded.
>>>>> > As far as I have tested Mixxx master tries to play these tracks but
>>>>> > without much luck. It produces only strange distorted sound.
>>>>> > However they are played fine with GStreamer based players. This is
>>>>> > probably due to the ffmpeg decoder, Mixxx uses the mad decoder.
>>>>> >
>>>>> > Unfortunately I cannot publish the tracks, because of copyright.
>>>>> >
>>>>> > For me this is a good sign for the new branch, It detects the faulty
>>>>> > file and not tries to play it which involves a crashing risk.
>>>>> > For me playing such distorted sound is a strong issue. This must not
>>>>> > happen during a gig.
>>>>> >
>>>>> > Can someone on this list confirm it with a similar test on Windows or
>>>>> > Mac on his own track collection?
>>>>> >
>>>>> >
>>>>> > Thank you for your help.
>>>>> >
>>>>> > Daniel
>>>>> >
>>>>> >
>>>>> > Am 11.04.2015 um 09:36 schrieb Daniel Schürmann:
>>>>> >> Hi,
>>>>> >>
>>>>> >> to continue toward fixing the mp3 seeks, wee need to have test data
>>>>> from
>>>>> >> all our build targets.
>>>>> >>
>>>>> >> Since RJ, the maintainer of our build server seams to have a leak of
>>>>> >> time,
>>>>> >> I am looking for an alternative solution to produce test builds of
>>>>> >> https://github.com/mixxxdj/mixxx/pull/411
>>>>> >>
>>>>> >> I have already tested it on Ubuntu Trusty 32 and 64 bit.
>>>>> >> So we need Windows and Mac test data the most.
>>>>> >>
>>>>> >> Who has a Mac or Windows build environment and some spare time to
>>>>> >> test the branch?
>>>>> >>
>>>>> >> Has anyone else access to the build server or an other way to offer
>>>>> >> test build
>>>>> >> for the public?
>>>>> >>
>>>>> >> Has anyone tracks that he provide to the testers that are known to
>>>>> >> crash Mixxx?
>>>>> >>
>>>>> >> Thank you very much!
>>>>> >>
>>>>> >> Kind regards,
>>>>> >>
>>>>> >> Daniel
>>>>> >>
>>>>> >>
>>>>> >>
>>>>> >>
>>>>> >>
>>>>> >>
>>>>> >> Am 29.03.2015 um 00:21 schrieb Daniel Schürmann:
>>>>> >>> Hi,
>>>>> >>>
>>>>> >>> if we want to call out a new sound source API test phase,
>>>>> >>> the easter days seams to be a nice period.
>>>>> >>>
>>>>> >>> Are there any volunteers with a Windows or Mac buid environment?
>>>>> >>> This is the link to clone the branch:
>>>>> >>> https://github.com/uklotzde/mixxx.git
>>>>> >>>
>>>>> >>> Independent from the question if it should become part of the
>>>>> >>> 1.12 alpha, it is a good idea to prepare test build for all
>>>>> platforms.
>>>>> >>>
>>>>> >>> @rryan: How do you thing about the temporary merge idea?
>>>>> >>> Or is it just as easy to make our buildservers watch for Uwes
>>>>> branch
>>>>> >>> for a night without messing with master git history?
>>>>> >>>
>>>>> >>> Or does anyone have a better idea?
>>>>> >>>
>>>>> >>> Thanks,
>>>>> >>>
>>>>> >>> Daniel
>>>>> >>>
>>>>> >>>
>>>>> >>> Am 27.03.2015 um 13:26 schrieb Daniel Schürmann:
>>>>> >>>> Hi,
>>>>> >>>>
>>>>> >>>> On one hand we have a ready branch, solving a seek issue in the
>>>>> most
>>>>> >>>> common mp3 format.
>>>>> >>>> On the other hand we have the fear of introducing critical bugs
>>>>> and
>>>>> >>>> loosing reputation because of this.
>>>>> >>>>
>>>>> >>>> The branch meets all quality requirements, It was reviewed (every
>>>>> >>>> single
>>>>> >>>> line) and has unit test.
>>>>> >>>> It was improved by > 100 comments during a review phase of nearly
>>>>> three
>>>>> >>>> month.
>>>>> >>>>
>>>>> >>>> There is only one thing missing, results from a comprehensive
>>>>> test with
>>>>> >>>> all sorts of files.
>>>>> >>>>
>>>>> >>>> The problem is that we will never get this results. Not before
>>>>> >>>> releasing
>>>>> >>>> a 1.12 beta,
>>>>> >>>> and not before releasing a 1.13 beta in three month or two years.
>>>>> >>>>
>>>>> >>>> During my review I got the impressin that this branch is a stably
>>>>> win
>>>>> >>>> and will probably fix more crasher
>>>>> >>>> bug than it introduces.
>>>>> >>>>
>>>>> >>>> So what about this:
>>>>> >>>> * Lets schedule publish of the beta next week
>>>>> >>>> * Merge the API branch now, wait for binaries and revert it.
>>>>> >>>> * Ask all on this list to compare the API build with the previous
>>>>> >>>> master.
>>>>> >>>> * Count crashes from the patched API version with the unpatched
>>>>> >>>> version.
>>>>> >>>>
>>>>> >>>> The winner is the new alpha.
>>>>> >>>> Take the API version on draw
>>>>> >>>>
>>>>> >>>> What do you think?
>>>>> >>>>
>>>>> >>>> Kind regards,
>>>>> >>>>
>>>>> >>>> Daniel
>>>>> >>>>
>>>>> >>>>
>>>>> >>>>
>>>>> >>>> Am 27.03.2015 um 10:52 schrieb Tuukka Pasanen:
>>>>> >>>>> Hello,
>>>>> >>>>> We deficiently should get into beta stage. Not allowing no more
>>>>> new
>>>>> >>>>> features and just push them to 1.12. Like rryan said this is huge
>>>>> >>>>> update and 1.13 will be much larger with that new audio interface
>>>>> >>>>> stuff (I should dig into FFmpeg stuff again). I don't think
>>>>> everything
>>>>> >>>>> will be in order when 1.12 is released and big audience starts
>>>>> digging
>>>>> >>>>> in. There will be bugs and there will be pain but we shouldn't
>>>>> stop it
>>>>> >>>>> coming because longer we hold these back longer will be pain
>>>>> section
>>>>> >>>>> because everyone starts to fear ghosts.
>>>>> >>>>>
>>>>> >>>>> Tuukka
>>>>> >>>>>
>>>>> >>>>> 2015-03-24 16:51 GMT+02:00 Sean M. Pappalardo - D.J. Pegasus
>>>>> >>>>> <spappala...@mixxx.org>:
>>>>> >>>>>> Hello again.
>>>>> >>>>>>
>>>>> >>>>>> I'm getting the idea that you guys are so anxious for a release
>>>>> >>>>>> that you're
>>>>> >>>>>> acting like we're most of the way through a beta period. If
>>>>> that's
>>>>> >>>>>> how you
>>>>> >>>>>> feel, cut a damn branch already and release an official alpha so
>>>>> >>>>>> we can
>>>>> >>>>>> merge otherwise-ready things into master and eliminate tensions.
>>>>> >>>>>>
>>>>> >>>>>> I just fear that Mixxx 1.12 won't be as good as it could be if
>>>>> we
>>>>> >>>>>> don't
>>>>> >>>>>> merge ready things. But I acknowledge there's nothing wrong with
>>>>> >>>>>> or stopping
>>>>> >>>>>> us from releasing a 1.13 in 3-6 months.
>>>>> >>>>>>
>>>>> >>>>>>
>>>>> >>>>>> Sincerely,
>>>>> >>>>>> Sean M. Pappalardo
>>>>> >>>>>> "D.J. Pegasus"
>>>>> >>>>>> Mixxx Developer - Controller Specialist
>>>>> >>>>>>
>>>>> >>>>>>
>>>>> >>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> >>>>>>
>>>>> >>>>>> Dive into the World of Parallel Programming The Go Parallel
>>>>> Website,
>>>>> >>>>>> sponsored
>>>>> >>>>>> by Intel and developed in partnership with Slashdot Media, is
>>>>> your
>>>>> >>>>>> hub for
>>>>> >>>>>> all
>>>>> >>>>>> things parallel software development, from weekly thought
>>>>> >>>>>> leadership blogs
>>>>> >>>>>> to
>>>>> >>>>>> news, videos, case studies, tutorials and more. Take a look and
>>>>> >>>>>> join the
>>>>> >>>>>> conversation now. http://goparallel.sourceforge.net/
>>>>> >>>>>> _______________________________________________
>>>>> >>>>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>>>>> >>>>>> http://mixxx.org
>>>>> >>>>>>
>>>>> >>>>>>
>>>>> >>>>>> Mixxx-devel mailing list
>>>>> >>>>>> Mixxx-devel@lists.sourceforge.net
>>>>> >>>>>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>>>> >>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> >>>>>
>>>>> >>>>> Dive into the World of Parallel Programming The Go Parallel
>>>>> >>>>> Website, sponsored
>>>>> >>>>> by Intel and developed in partnership with Slashdot Media, is
>>>>> your
>>>>> >>>>> hub for all
>>>>> >>>>> things parallel software development, from weekly thought
>>>>> >>>>> leadership blogs to
>>>>> >>>>> news, videos, case studies, tutorials and more. Take a look and
>>>>> >>>>> join the
>>>>> >>>>> conversation now. http://goparallel.sourceforge.net/
>>>>> >>>>> _______________________________________________
>>>>> >>>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>>>>> >>>>> http://mixxx.org
>>>>> >>>>>
>>>>> >>>>>
>>>>> >>>>> Mixxx-devel mailing list
>>>>> >>>>> Mixxx-devel@lists.sourceforge.net
>>>>> >>>>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>>>> >>>
>>>>> >>
>>>>> >
>>>>> >
>>>>> >
>>>>> ------------------------------------------------------------------------------
>>>>> > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
>>>>> > Develop your own process in accordance with the BPMN 2 standard
>>>>> > Learn Process modeling best practices with Bonita BPM through live
>>>>> exercises
>>>>> > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual-
>>>>> event?utm_
>>>>> >
>>>>> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
>>>>> > _______________________________________________
>>>>> > Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>>>>> > http://mixxx.org
>>>>> >
>>>>> >
>>>>> > Mixxx-devel mailing list
>>>>> > Mixxx-devel@lists.sourceforge.net
>>>>> > https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
>>>>> Develop your own process in accordance with the BPMN 2 standard
>>>>> Learn Process modeling best practices with Bonita BPM through live
>>>>> exercises
>>>>> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual-
>>>>> event?utm_
>>>>> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
>>>>> _______________________________________________
>>>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>>>>> http://mixxx.org
>>>>>
>>>>>
>>>>> Mixxx-devel mailing list
>>>>> Mixxx-devel@lists.sourceforge.net
>>>>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>>>>
>>>>
>>>>
>>>
>>
>>
>> ------------------------------------------------------------------------------
>> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
>> Develop your own process in accordance with the BPMN 2 standard
>> Learn Process modeling best practices with Bonita BPM through live
>> exercises
>> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual-
>> event?utm_
>> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
>> _______________________________________________
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>
>
>
>
> ------------------------------------------------------------------------------
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live
> exerciseshttp://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual-
> event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
>
>
>
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Todayhttp://mixxx.org
>
>
> Mixxx-devel mailing
> listMixxx-devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
>
>
>
> ------------------------------------------------------------------------------
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live
> exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual-
> event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
