On 4/27/06, Nathaniel Smith <[EMAIL PROTECTED]> wrote: > On Thu, Apr 27, 2006 at 01:57:21PM -0500, Timothy Brownawell wrote: > > > But when doing it > > > form the command line I can only assume that you folks don't like empty > > > commit messages. If that is the case I think that the second example > > > should > > > fail too (only white space in commit message). > > > > It's the default version of the validate_commit_message hook. I don't > > think it's a very good default, so would anyone object to removing it? > > Ah-hah, is that what it is! I had been wondering, since we pretty > much hashed this out before: > http://thread.gmane.org/gmane.comp.version-control.monotone.devel/4365 > and I thought we had decided that -m "" should just work, if someone > was going to bother doing it. I guess we made that work, and then the > validate_commit_message change changed it again? > > IMHO the validate_commit_message hook should default to accepting > _all_ messages, while keeping the current "empty commit message > in an editor means cancel this commit" behavior. >
::shrug:: that works too. As long as en empty commit message from an editor means abort I'll be happy. -- Justin Patrin _______________________________________________ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel
