Am 12.05.10 18:26, schrieb Derek Scherger: >> >> On Mon, May 10, 2010 at 3:53 PM, Thomas Keller <m...@thomaskeller.biz>wrote: >> >>>> * #20447: mtn diff <filename> fails inside of a renamed directory >>>> -> net.venge.monotone.bugfest-2010.20447-dscherger >>>> -> @Derek: whats your plan here? Is this reviewable? >>> >>> Patch looks ok, if you add tests for the new diff behaviour (/dev/null >>> in adds and file removals) and check the patch(1) compatibility, I'll >>> reward that with an 8. >>> >> > I've added a bunch of tests and noticed that there are several xfailed diff > tests that are related to the same problem of a restriction excluding > parents of a file. Seeing all these I'm pretty much convinced that making a > change so that parent nodes get included is the right thing to do, or is at > least better than what we're doing now. I don't think this should be too > hard to do so I may have a look at it in the not-too-distant future. I'd > like to get the changelog branch wrapped up first though.
There shouldn't be much missing - we've only talked about log preserving last time, right? >> Note that you based this work on the code of #12273 - so only merge it >>> into mainline afterwards when you had the time to manage the shortening >>> of the ls tags output there :) >>> >> > Fixed, tested and merged. We can think about adding a --verbose option for > things like this any time. Yeah, I've seen that - cool! For the others: If you think your branch is ready for the final merge, give me a note if you want to get it reviewed another time, otherwise just merge it. Thomas. -- GPG-Key 0x160D1092 | tommyd3...@jabber.ccc.de | http://thomaskeller.biz Please note that according to the EU law on data retention, information on every electronic information exchange might be retained for a period of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel