All good information, thank you. On my side I'm going to try and setup a
reproducible test case so we can know when we've fixed the bug.
On Sat, Mar 4, 2017 at 8:59 PM Stephen Lyons <slys...@virginmedia.com>
wrote:
> I still think that the way we process incoming MUD data could be suspect
> in that (void)cTelnet::handle_socket_signal_readyRead() is a SLOT that
> is coupled to an asynchronous SIGNAL generated by a separate (Qt
> provided) network thread that manages (QTcpSocket)cTelnet::socket so we
> have to be careful to make any class members it modifies be used in a
> re-entrant or is that thread-safe manner? I.e.:
>
> Looks contentious:
> (bool)Host::mInsertedMissingLF
> (bool)cTelnet::recvdGA
> (bool)cTelnet::iac
> (bool)cTelnet::iac2
> (bool)cTelnet::insb
> (std::string)cTelnet::command
>
> Safe-ish probably only because they are not modified frequently:
> (bool)cTelnet::mMCCP_version_1
> (bool)cTelnet::mMCCP_version_2
> (bool)cTelnet::mFORCE_GA_OFF
> (bool)cTelnet::mGA_Driver
> (bool)cTelnet::mLF_ON_GA
> (bool)cTelnet::mNeedDecompression
> (bool)TConsole::mRecordReplay
>
> Probably safe:
> (bool)cTelnet::mWaitingForResponse
> (QTime)cTelnet::timeOffset
> (QTime)cTelnet::networkLatencyTime
> (double)cTelnet::networkLatency
>
> Note that "command" in void cTelnet::processTelnetCommand(const string
> &) is a local variable {the passed argument, NOT the class member of the
> same name which it masks - tut, tut!}
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1374684
>
> Title:
> Crash on using the search box
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mudlet/+bug/1374684/+subscriptions
>
--
You received this bug notification because you are a member of Mudlet
Makers, which is subscribed to Mudlet.
https://bugs.launchpad.net/bugs/1374684
Title:
Crash on using the search box
Status in Mudlet:
New
Bug description:
See http://forums.mudlet.org/viewtopic.php?f=9&t=4598&p=21696#p21693
and http://forums.mudlet.org/viewtopic.php?f=9&t=4598&start=40#p21611
for two reports of this happening.
Just clicking on the search box can cause a crash:
http://forums.mudlet.org/viewtopic.php?f=5&t=4695&start=30#p22489
Different stacktraces, just clicking on the search bar does it:
https://bugs.launchpad.net/mudlet/+bug/1416757
http://pastebin.com/fTnNqeQD
http://pastebin.com/njWHEEvK
http://pastebin.com/sqMsbVKq
http://pastebin.com/wtSegBRW
Haven't gotten a detailed and a reproducible test case yet, though.
Qt bugreport: https://bugreports.qt.io/browse/QTBUG-44244
To manage notifications about this bug go to:
https://bugs.launchpad.net/mudlet/+bug/1374684/+subscriptions
_______________________________________________
Mailing list: https://launchpad.net/~mudlet-makers
Post to : mudlet-makers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mudlet-makers
More help : https://help.launchpad.net/ListHelp
