Nigel,

After your check-in, I get this on my system when I try to compile:

filter_linearblend.c: In function `linearBlendFilter':
filter_linearblend.c:326: warning: empty body in an if-statement
filter_linearblend.c: In function `new_filter':
filter_linearblend.c:358: error: `linearBlendMMX' undeclared (first use in this function)
filter_linearblend.c:358: error: (Each undeclared identifier is reported only once
filter_linearblend.c:358: error: for each function it appears in.)
filter_linearblend.c:360: error: `linearBlend3DNow' undeclared (first use in this function)

The reason is that I am on a x86_64 system, which doesn't have i386 defined, but I do have MMX defined. The definition of those functions are inside of a #ifdef i386, but the use of the function is within #ifdef MMX. I would suggest changing the #ifdef statement in line 356 of filter_linearblend.c from:

#ifdef MMX

to

#if defined(MMX) && defined (i386)

Thanks,
Harvard

On 5/23/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
----------------------------------------------------------------------------
Changes committed by nigel on Tue May 24 01:25:48 2005

Added Files:
   in mythtv/filters:
        filter-avcodec.pro filter-common.pro mm_arch.h
Modified Files:
   in mythtv/filters/adjust:
        adjust.pro filter_adjust.c
   in mythtv/filters/bobdeint:
        bobdeint.pro
   in mythtv/filters/convert:
         convert.pro
   in mythtv/filters/crop:
        crop.pro filter_crop.c
   in mythtv/filters/denoise3d:
        denoise3d.pro filter_denoise3d.c
   in mythtv/filters/force:
        force.pro
   in mythtv/filters/invert:
        invert.pro
   in mythtv/filters/kerneldeint:
        filter_kerneldeint.c kerneldeint.pro
   in mythtv/filters/linearblend:
        filter_linearblend.c linearblend.pro
   in mythtv/filters/onefield:
         onefield.pro
   in mythtv/filters/postprocess:
        postprocess.pro
   in mythtv/filters/quickdnr:
        filter_quickdnr.c quickdnr.pro
Log Message:
1 - Abstraction of common stuff from all the .pro files
2 - Removal of dummy functions that are not needed on non-MMX
3 - Determine Altivec acceleration at runtime (currently linearblend only)
4 - Tidy comments after #endifs (remove, or make C style in .c src)

----------------------------------------------------------------------------


_______________________________________________
mythtv-commits mailing list
mythtv-commits@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits



_______________________________________________
mythtv-dev mailing list
mythtv-dev@mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev

Reply via email to