Jerome, I don't suppose you could also re-write the code to use DotNetZip instead of SharpZipLib? :-) The reason I'm mentioning this is because 1) DotNetZip is maintained, and SharpZipLib no longer seems to be 2) DotNetZip supports multithreaded zip compression, which is a huge gain for practically any machine now
Binary reference .dll size is 200k (Reduced, i.e. no self-extracting archive creation support), so the same as SharpZipLib that NAnt currently ships with. On Thu, Dec 13, 2012 at 3:06 PM, Ryan Boggs <[email protected]> wrote: > Sorry, forgot to CC list. > > Thanks, > Ryan > > ---------- Forwarded message ---------- > From: Ryan Boggs <[email protected]> > Date: Thu, Dec 13, 2012 at 7:04 AM > Subject: Re: [nant-dev] Adding an update parameter to the <zip> task > To: [email protected] > > > Hi Jerome, > > If you don't mind, could you please open up a pull request via github > with this change? It's easier for us (me at least) to review > contributions this way. > > NAnt/NAntContrib Dev Guide: > https://github.com/nant/nant/wiki/Development-Guide > > Github Pull Request Guide: > https://help.github.com/articles/using-pull-requests > > Thanks, > Ryan > > On Thu, Dec 13, 2012 at 5:32 AM, <[email protected]> wrote: >> Attached is a first draft of a >> https://github.com/nant/nant/tree/master/src/NAnt.Compression/Tasks/ZipTask.cs >> version allowing to append files to an existing zip archive (see >> http://ant.apache.org/manual/Tasks/zip.html). >> Is it worth writing a unit test for it? What do you think? >> /J >> >> ------------------------------------------------------------------------------ >> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial >> Remotely access PCs and mobile devices and provide instant support >> Improve your efficiency, and focus on delivering more value-add services >> Discover what IT Professionals Know. Rescue delivers >> http://p.sf.net/sfu/logmein_12329d2d >> _______________________________________________ >> nant-developers mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/nant-developers >> > > ------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > nant-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/nant-developers ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ nant-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/nant-developers
