NS_FATAL doesn't make any sense.  Fatal means unrecoverable error, as
in Ns_Fatal(...): and the server exits.

Anyway, the following two disagree.  Whether they intend "request
cannot be parsed" or "driver function not supported", NS_FATAL isn't
the way to say it.


/*
*----------------------------------------------------------------------
*
* Ns_DriverSetRequest --
*
*      Parses request line and sets as current Request struct, should be
*      in the form: METHOD URL ?PROTO?
*
* Results:
*      NS_ERROR in case of empty line
*      NS_FATAL if request cannot be parsed.
*      NS_OK if parsed sucessfully
*
* Side effects:
*      This is supposed to be called from drivers before the
*      socket is queued, usually from DriverQueue command.
*      Primary purpose is to allow non-HTTP drivers to setup
*      request line so registered callback proc will be called
*      during connection processing
*
*----------------------------------------------------------------------
*/

/*
*----------------------------------------------------------------------
*
* SockQueue --
*
*      Puts socket into connection queue
*
*      Call driver's queue handler for the last checks before actual
*      connection enqueue. NS_ERROR is valid here because that means
*      driver does not implement this call, we care about NS_FATAL status
*      only which means we cannot queue this socket. It is driver's
responsibility
*      to allocate Request structure via Ns_DriverSetRequest call, otherwise
*      for all non-HTTP or not-parsed sockets this call will fail
*
* Results:
*      NS_OK if queued,
*      NS_ERROR if socket closed because of error
*      NS_TIMEOUT if queue is full
*
* Side effects:
*      None
*
*----------------------------------------------------------------------
*/

Reply via email to