On Tue, 2006-31-01 at 01:16 +0100, Patrick McHardy wrote:
> David S. Miller wrote:
> > From: dean gaudet <[EMAIL PROTECTED]>
> > Date: Sat, 17 Dec 2005 18:22:40 -0800 (PST)
> > 
> > 
> >>let me know what you think... i'd like to get something like this patch
> >>included upstream so i can eliminate a patch from several of my kernels.
> > 
> > 
> > The RTA length check is a little hackish.  Maybe use a new
> > attribute?  That's usually the way to extend netlink things.
> > 
> > I have no opinion about this feature, can others comment
> > please?
> 
> I think this should be done the way ESFQ does it by adding seperate hash
> functions. 

yes that would be a lot cleaner than the posted patch. Actually even
better is to pass exactly what should be used for hashing (else you use
the current defined hash).

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to