Arjan van de Ven wrote:
Jeff Garzik wrote:
The driver's locking is definitely wrong, but I don't think this is
the fix,
it's an obvious correct fix in the correctness sense though...
Jesus, the locking here is awful. No wonder there are bugs.
... which given that fact, is for 2.6.17 probably the right thing, pending
a nicer fix for 2.6.18
I disagree, the patch is wrong too.
For normal PCI hardware, the in-ISR paths should all use spin_lock(),
and the outside-ISR paths should use either spin_lock_irq() or
spin_lock_irqsave().
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
