From: Gerrit Renker <[EMAIL PROTECTED]> Date: Tue, 6 Jun 2006 19:25:40 +0100
> Fix: Move the `UDP_INC_STATS_BH(UDP_MIB_INDATAGRAMS)' statement from > udp_queue_rcv_skb to udp_recvmsg. Now InDatagrams only counts those > datagrams which were really delivered (as per RFC 2013). > > Please CC: any correspondence to [EMAIL PROTECTED] > > Signed-off-by: <[EMAIL PROTECTED]> Unfortunately this breaks NFS and other in-kernel UDP socket usages, which never call recvmsg() and instead take the packet via the ->data_ready() callback done by sock_queue_receive_skb(). Your patch will make the counter never get incremented when such a user is using the UDP socket. Probably a better way to handle this is to correct the INDATAGRAMS value by decrementing it when we notice that the checksum is incorrect in a deferred manner. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
