From: Samuel Ortiz <[EMAIL PROTECTED]>
Date: Wed, 19 Jul 2006 08:13:31 +0300

> As pointed out by Christoph Hellwig, dev_alloc_skb() is not intended to be
> used for allocating TX sk_buff. The IrDA stack was exclusively calling
> dev_alloc_skb() on the TX path, and this patch fixes that.
> 
> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>

Applied, thanks Samuel.

As followups it would be nice to:

1) See if any of the GFP_ATOMIC's can be moved to GFP_KERNEL.
   I do understand that many of these call sites are running
   in software interrupt context or are holding spinlocks and
   thus must use GFP_ATOMIC.

2) Change these 64 and 128 constant sizes to something with
   a name.

Thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to