Lennert Buytenhek <[EMAIL PROTECTED]> writes: > On Mon, Dec 04, 2006 at 10:27:52AM -0800, Dan Nicolaescu wrote: > > > > > The Opencores Ethernet Controller is Verilog code that can be used to > > > > implement an Ethernet device in hardware. It needs to be coupled with > > > > a PHY and some buffer memory. Because of that devices that implement > > > > this controller can be very different. The code here tries to support > > > > that by having some parameters that need to be defined at compile > > > > time. > > > > > > Considering this, why don't you make it a platform driver? > > > > I didn't know about "platform drivers" before your mail. I guess I > > could convert it to that if that is the right thing to do. > > I definitely think so. Check the ep93xx_eth driver for an example. > > > > (It might be an overkill given that the device is kind of simple and > > embedded people prefer small code...) > > ..until someone decides that he wants to build a design with two of > these ethernet cores instead of just one, at which point the entire > "Let's use #defines for everything" plan breaks down badly.
Sure. If changing the code to implement a platform driver is required in order to get it accepted, then I'll do that. If it's not required, the platform driver code can be added later as an incremental patch. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
