On Sat, 3 Feb 2007 17:25:18 +0100, Ivo van Doorn wrote: > When rt2500usb and rt73usb will start using beacontemplates, > they would also need a control structure to be passed along to > correctly set the tx parameters.
Good catch, thanks. > This patch will add the allocation an initialization of a > ieee80211_tx_control especially for the beacontemplate. > > This does require drivers that have the BEACON_TEMPLATE flag > set to also free the control structure. (bcm43xx and p54 will be > fixed in the next 2 patches) I would prefer using local variable for tx_control. Driver will be responsible for copying it somewhere if it needs to. I believe most drivers won't need to do that and it will prevent potential memory leaks as it's easy to forget to free the structure. Thanks, Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html