Atsushi Nemoto wrote:
On Sat, 28 Apr 2007 11:10:37 -0400, Jeff Garzik <[EMAIL PROTECTED]> wrote:
 static unsigned int netcard_portlist[] __initdata = {
-       0x300, 0x280, 0x320, 0x340, 0x360, 0x380, 0
+#if defined(CONFIG_ISA) || defined(CONFIG_M32R)
+       0x300, 0x280, 0x320, 0x340, 0x360, 0x380,
+#endif
+       0
This looks a bit strange, and perhaps more difficult to maintain long term.

I would suggest creating a NEEDS_PORTLIST cpp macro at the top of ne.c, to be defined or undefined based on CONFIG_xxx symbols. Then, down in the code itself, conditionally include or exclude all portlist related data tables and code.

Sound sane?

Sure.  Do you mean something like this?

Correct.

        Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to