From: jamal <[EMAIL PROTECTED]> Date: Fri, 27 Apr 2007 10:29:28 -0400
> On Fri, 2007-27-04 at 15:55 +0200, Patrick McHardy wrote: > > > > > It it really worth the extra code for dumping them conditionally? > > The attributes are neither large nor will they be sent very often. > > > > That thought did cross my mind when i was coding this;-> I hate the way > netlink filters are done in user space with iproute2 - dumping 50 > objects just so i can get to one. So i used that as my guiding > principle; i have no qualms with the few extra lines. > Actually, I was hoping it would provide motivation for someone else to > do a better filtering scheme (which sits in the kernel). I think filtering in the kernel makes sense when the kernel is in a unique place to make the algorithmic complexity of the filtering minimal. The TCP socket dumping is a good example of that. For things like this I think it's really unnecessary. Figure out what the basic information is and just provide it every time. You have a full release cycle to work out what that is, and if we miss anything, afterwards we can still extend with attributes. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html