On Wed, Jul 03, 2019 at 01:26:49AM +0200, Pablo Neira Ayuso wrote:
> On Mon, Jul 01, 2019 at 10:16:43PM +0200, Ander Juaristi wrote:
> > diff --git a/include/nftables/libnftables.h b/include/nftables/libnftables.h
> > index e39c588..87d4ff5 100644
> > --- a/include/nftables/libnftables.h
> > +++ b/include/nftables/libnftables.h
> > @@ -52,6 +52,7 @@ enum {
> >     NFT_CTX_OUTPUT_NUMERIC_PROTO    = (1 << 7),
> >     NFT_CTX_OUTPUT_NUMERIC_PRIO     = (1 << 8),
> >     NFT_CTX_OUTPUT_NUMERIC_SYMBOL   = (1 << 9),
> > +   NFT_CTX_OUTPUT_SECONDS          = (1 << 10),
> 
> I'd rename this to:
> 
>         NFT_CTX_OUTPUT_NUMERIC_TIME

NFT_CTX_OUTPUT_SECONDS is also fine.

I let you choose.

> 
> >     NFT_CTX_OUTPUT_NUMERIC_ALL      = (NFT_CTX_OUTPUT_NUMERIC_PROTO |
> >                                        NFT_CTX_OUTPUT_NUMERIC_PRIO |
> >                                        NFT_CTX_OUTPUT_NUMERIC_SYMBOL),
> 
> You have to update NFT_CTX_OUTPUT_NUMERIC_ALL.

But you still have to update this :-)

Reply via email to