On 2016-12-21 at 10:13:03 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > On Wed, Dec 21, 2016 at 10:17:17AM +0100, Tobias Klauser wrote: > > On 2016-12-20 at 22:10:54 +0100, Vadim Kochan <vadi...@gmail.com> wrote: > > > On Tue, Dec 20, 2016 at 12:33:47PM +0100, Tobias Klauser wrote: [...] > > > > And third, it's not immediately intuitive to which item the index > > > > refers, i.e. is the MAC address ab:bb:cc:dd:ee:ff afterwards or > > > > aa:bb:cc:dd:ee:00? > > > > > > Indexing starts from 0 byte in the network order, please see a below > > > examples of > > > trafgen + netsniff-ng outputs: > > > > Ok. Could you please mention this fact (that indices start from byte 0 > > in network order) in the man page? > > > > Hm, actually I did it in the man patch, but may be too shortly ...
Oops, sorry. I obviously didn't read the patch careful enough. Maybe you could add one of the examples to the man page as well to make it immediately obvious what the result will be? [...] > > > > Let me think about this a bit more... > > > > > > I think we can have 1 or 3 different solutions: > > > > > > 1) Current > > > > > > 2) Current + function param default value > > > > > > 3) Array-like > > > > I'll go ahead and apply your series except for the man page patch. Could > > you please send an update for this one incorporating the changes > > mentioned above? > > > > From there on we could then think about implementing option 3 in > > addition... > > > > Thanks a lot! > > Sure I will collect your comments and use them for man page update. Great, thanks. Tobias -- You received this message because you are subscribed to the Google Groups "netsniff-ng" group. To unsubscribe from this group and stop receiving emails from it, send an email to netsniff-ng+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
