Hi Girish, On Wed, 16 Jul 2008, Girish M G wrote:
> The webrev is located here: > http://cr.opensolaris.org/~girishmg/tcpsig/ I read through the TCP changes and they look good. One minor observation: - SACK becomes conditional on !TCP-MD5 in a few places, is this always required? E.g. places where: if (tcp->tcp_snd_sack_ok ..... become if (!tcp->tcp_signature) { if (tcp->tcp_snd_sack_ok ..... } seems confusing to future readers, at best (if not a bug waiting to happen when someone forgets to test tcp_signature - why is tcp_snd_sack_ok true when it's not OK?). See <-23522,21 +23716,24>, <-12764,10 +12847,41>, <-13630,16 +13768,41> etc. regards, -- Paul Jakma [EMAIL PROTECTED] [EMAIL PROTECTED] Key ID: 64A2FF6A Fortune: To get back on your feet, miss two car payments. _______________________________________________ networking-discuss mailing list [email protected]
