Renee Danson wrote: > Hello, > > I'm requesting feedback on the following bugfix: > > http://cr.opensolaris.org/~okie/6727748/ > > This fixes CR 6727748: nwam fails to update dns information on wireless > link.
I've seen this regularly with bge0 and ath0 when in GMP03. The approach to the fix makes sense to me given how I've observed the problem. DJM-1 usr/src/cmd/cmd-inet/sbin/netstrategy/netstrategy.c:170 I don't follow why interface is declared static, what am I missing ? It looks to me like we only return use interface (and return it) if found_one is true and in that case we have also done a strncpy into interface. DJM-2 usr/src/cmd/cmd-inet/sbin/netstrategy/netstrategy.c:204,242 I think these strncpy can be replaced with the safer strlcpy. DJM-3 usr/src/cmd/cmd-inet/sbin/netstrategy/netstrategy.c:199 Existing logic, but why do we skip logical interfaces ? Zones without exclusive IP stack often have logical interfaces. I don't expect this to be changed for this bug fix just curious. DJM-4 usr/src/cmd/cmd-inet/sbin/netstrategy/netstrategy.c:235 The comment about only having one interface is out of date especially given the whole reason for this fix. I think the rest is fine, you can list me as a codereviewer. -- Darren J Moffat _______________________________________________ networking-discuss mailing list [email protected]
