[ 
https://issues.apache.org/jira/browse/OFBIZ-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301138#comment-16301138
 ] 

Michael Brohl commented on OFBIZ-9536:
--------------------------------------

Hi Nicolas, 

the code style looks good to me, maybe except the initialization of 
carriageReturnType with "" instead of null.
If you like you can commit it along with your other improvement, no problem.

> IN CSV export file from record add a new attribut to select the caraige 
> return type
> -----------------------------------------------------------------------------------
>
>                 Key: OFBIZ-9536
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9536
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Gaudin Pierre
>            Assignee: Michael Brohl
>         Attachments: ModelRecord.patch
>
>
> During the generation of a file of the type CSV via a record, it is not 
> possible to choose the type for the end of line. It is systematically of the 
> type " CR ". This patch has for objective to make possible the choice between 
> "CR" and CRLF " by the addition of an new attribute " carriageReturnType " in 
> the record tag. The value by default is "CR".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to