[ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572942#comment-16572942
 ] 

Mathieu Lirzin edited comment on OFBIZ-10438 at 8/8/18 9:43 AM:
----------------------------------------------------------------

{quote}
Can I bother you to refresh my memory? What are we going to do here? Just a 
brief of what you want to do?
{quote}

To summarize this patch series is about adding support for the "method" 
attribute and allowing multiple request maps with the same URI but with 
different method. Is it precise enough? Feel free to ask more specific questions


was (Author: mthl):
{quote}
Can I bother you to refresh my memory? What are we going to do here? Just a 
brief of what you want to do?
{quote}

To summarize this patch series is about adding support for the "method" 
attribute and allowing multiple request maps with the same URI but with 
different method.

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10438
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10438
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Shi Jinghai
>            Assignee: Shi Jinghai
>            Priority: Minor
>         Attachments: 
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch, 
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch, 
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> <request-map uri="examples" method="get">
>    <security https="true" auth="true"/>
>    <event type="java" path="ExamplesHandlers" invoke="getExamples"/>
>    <response name="success" type="view" value="..."/>
>    <response name="error" type="view" value="..."/>
> </request-map>
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> <request-map uri="examples" method="get,post">...</request-map>
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to