[ https://issues.apache.org/jira/browse/OFBIZ-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602963#comment-16602963 ]
Arsalane Arrach edited comment on OFBIZ-10511 at 9/4/18 12:08 PM: ------------------------------------------------------------------ Hey, I have a little improvement suggestion concerning how the syntax error was handled. The patch OFBIZ-10511 came with two contributions: # The first contribution being the one mentioned in this thread, that is, using an antislash to escape the double quotes used while building the params-variable. # The second contribution was to change the double quotation marks to single quotation marks in the assignment to the variable named data-dialog-params. Without this modification, we still get syntax errors. Whilst this solves the problem, a perhaps better practice would be to use " in order to escape the double quotation marks, as it is described in the [Apache Freemarker Manual |https://freemarker.apache.org/docs/dgui_misc_autoescaping.html] That way we don't have to apply change #2, as this impairs the coherence of how variables are assigned inside the link. Some with double quotes and some others with single quotes. I think it makes more sense to fix how the object (containing params) is constructed since this is the syntactic recommended - and therefore correct - approach of the previously cited manual. was (Author: aarrach): Hey, I have a little improvement suggestion concerning how the syntax error was handled. The patch OFBIZ-10511 came with two contributions: # The first contribution being the one mentioned in this thread, that is, using an antislash to escape the double quotes used while building the params-variable. # The second contribution was to change the double quotation marks to single quotation marks in the assignment to the variable named data-dialog-params. Without this modification, we still get syntax errors. Whilst this solves the problem, a perhaps better practice would be to use " in order to escape the double quotation marks, as it is described in the [ Apache Freemarker Manual | https://freemarker.apache.org/docs/dgui_misc_autoescaping.html]That way we don't have to apply change #2, as this impairs the coherence of how variables are assigned inside the link. Some with double quotes and some others with single quotes. I think it makes more sense to fix how the object (containing params) is constructed since this is the syntactic recommended - and therefore correct - approach of the previously cited manual. > Use of layered-modal with parameter does not work > ------------------------------------------------- > > Key: OFBIZ-10511 > URL: https://issues.apache.org/jira/browse/OFBIZ-10511 > Project: OFBiz > Issue Type: Bug > Affects Versions: Trunk, Release Branch 17.12 > Reporter: Gil Portenseigne > Assignee: Gil Portenseigne > Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-10511-reproduceBug.patch, OFBIZ-10511.patch > > > When using layered-modal with a parameter, those param are not parsed by js > when doing post request (the constructed map stay, and is send as one > parameter with no value...). > Though no parameter can be passed to the request. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)