[ 
https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606074#comment-17606074
 ] 

Ingo Wolfmayr commented on OFBIZ-12390:
---------------------------------------

[~jamesyong] : the order calculation and invoice calculation are correct and 
the results are even. Creating an invoice from an order will add all necessary 
adjustments (like VAT_CORRECTION). I did not see any problem here.

The order payment preference uses the cart "displayGrandTotal" to create the 
value. Using the cart (ecommerce, update order, webpos ...) the 
displayGrandTotal with the example provided will always result in a different 
value. The order items are stored with 3 decimals. The problem, as far as I can 
see, is not a missing adjustment but a different logic/timing in rounding when 
summing up the order/cart/invoice lines. When using the cart object, the 
rounding for the same order line is not limited.

Rounding the cart line subtotal before building the grand total (for Display) 
solved it - order & invoice are doing it that way.

Does not rule out that I am missing something. :)

> Order/Invoice: Item total result diff total result
> --------------------------------------------------
>
>                 Key: OFBIZ-12390
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12390
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, order
>    Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch
>            Reporter: Ingo Wolfmayr
>            Assignee: Jacques Le Roux
>            Priority: Major
>         Attachments: Orders.xml, cartRounding.patch, 
> image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, 
> image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, 
> pricecheckData-1.xml
>
>
> In some cases the order total is not correct:
> net price: €1.273
> 10% sales tax: € 0.127
> quantity: 1
> grand total: € 1.40
> Now taking the same product and adding it with two order lines:
> grand total: € 2.79
> Right now the grand total is calculated by total all item net prices, total 
> all adjustments and finally adding those two values together.
> The following screenshots are taken from the orderview. Ofbiz request a 
> payment of € 2.80 but will create an invoice with a grand total of € 2.79.
> !image-2021-11-19-09-44-18-759.png!
> !image-2021-11-19-09-44-44-443.png!
> Heres the result with just one orderline:
> !image-2021-11-19-09-59-07-571.png!
>  
> I have created a XML file for testing.  Import the file via XML import and 
> create an order:
> partyId: AUT_CUSTOMER
> productStore: Test GmbH
> product 1: AUT_PRODUCT (quantity 1)
> product 1: AUT_PRODUCT_CP (quantity 1)
> Checkout with default settings.
> From my perspective the calculation should be changed to calculate the total 
> amount for each line and calculate the grand total from these results.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to