[ 
https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748111#comment-17748111
 ] 

Michael Brohl commented on OFBIZ-9403:
--------------------------------------

[~cshan]  I think we should take the defaultMimeType from 
applications/content/config/content.properties instead of a hard coded one, can 
you please change it accordingly?

> DataResourceWorker: New method getMimeTypeFromFileName(...) with extracted 
> (refactored) code from getMimeType(...) method
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-9403
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9403
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: Trunk, Upcoming Branch
>            Reporter: Martin Becker
>            Assignee: Michael Brohl
>            Priority: Trivial
>         Attachments: OFBIZ-9403_DataResourceWorker_GetMimeType.patch, 
> OFBIZ-9403_DataResourceWorker_GetMimeType_with_defaultMimeTypeId.patch
>
>
> The method DataResourceWorker.getMimeType(GenericValue) has been refactored 
> into two separate methods. The new additional method 
> getMimeTypeFromFileName(Delegator,Filename) solely focuses on getting the 
> MimeType from the file extension and is invoked by getMimeType(GenericValue) 
> if needed. getMimeType returns the type if possible via the data resource. 
> This results in cleaner code with the responsibility of both methods clearly 
> defined by the methods names.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to