danwatford commented on PR #687: URL: https://github.com/apache/ofbiz-framework/pull/687#issuecomment-1926387962
> It's only a matter of performance for the hook. I'd like to have @danwatford's opinon about removing the compileGroovyScriptsGroovy Gradle task... Yes - the groovyScripts source set should be removed along with the changes to the compileGroovyScriptsGroovy task. This PR should be merged, with corresponding changes to the OFBiz buildbot definition to prevent build failure due to the absence of the build/reports/codenarc/groovyScripts.html file. Explanation given in comments here - https://issues.apache.org/jira/browse/OFBIZ-12888. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org