On Thursday 29 December 2005 20:46, Mike Frysinger wrote:
> all of the AC_ARG_ENABLE() macros used in configure.in set the 3rd option
> incorrectly ... find attached a patch to fix the issue

actually that patch is slightly broken as well ... at first glance i thought 
they were all AC_ARG_ENABLE() macros, but some are AC_ARG_WITH() macros, so 
need to use $withval instead of $enableval

updated patch attached
-mike
Index: configure.in
===================================================================
RCS file: /export/home/ntop/ntop/configure.in,v
retrieving revision 2.246
diff -u -p -r2.246 configure.in
--- configure.in	30 Nov 2005 20:53:13 -0000	2.246
+++ configure.in	30 Dec 2005 02:04:57 -0000
@@ -180,7 +180,7 @@ AC_ARG_ENABLE(showoses,
 dnl> Test before we use it, below
 AC_ARG_ENABLE(iknowbetter,
               [  --enable-iknowbetter        Override WILLFAIL],
-              ac_willfailoverride="yes",
+              ac_willfailoverride="$enableval",
               ac_willfailoverride="no")
 
 AC_ARG_ENABLE(void,
@@ -665,63 +665,63 @@ AC_ARG_WITH(void,
 
 AC_ARG_WITH(ssl,
               [  --without-ssl               disable HTPPS support [[default=enabled]]],
-              ac_disable_openssl="yes",
+              ac_disable_openssl="$withval",
               ac_disable_openssl="no")
 
 AC_ARG_WITH(zlib,
               [  --without-zlib              disable zlib [[default=enabled]]],
-              ac_disable_zlib="yes",
+              ac_disable_zlib="$withval",
               ac_disable_zlib="no")
 
 AC_ARG_ENABLE(sslv3,
               [  --enable-sslv3              enable ssl v3 support [[default=disabled]]],
-              ac_enable_sslv3="yes",
+              ac_enable_sslv3="$enableval",
               ac_enable_sslv3="no")
 
 AC_ARG_ENABLE(sslwatchdog,
               [  --enable-sslwatchdog        enable Watchdog for ssl hangups [[default=disabled]]],
-              ac_enable_sslwatchdog="yes",
+              ac_enable_sslwatchdog="$enableval",
               ac_enable_sslwatchdog="no")
 
 AC_ARG_WITH(tcpwrap,
               [  --with-tcpwrap              enable use of TCP Wrapper [[default=disabled]]],
-              ac_enable_tcpwrap="yes",
+              ac_enable_tcpwrap="$withval",
               ac_enable_tcpwrap="no")
 
 AC_ARG_ENABLE(plugins,
               [  --disable-plugins           disable compilation of plugins [[default=enabled]]],
-              ac_disable_plugins="yes",
+              ac_disable_plugins="$enableval",
               ac_disable_plugins="no")
 
 AC_ARG_ENABLE(  static-plugins,
               [  --enable-static-plugins     Enable static linked plugins [sntop, default=dynamic]]],
-              ac_enable_static_plugins="yes",
-	      ac_enable_static_plugins="no")
+              ac_enable_static_plugins="$enableval",
+              ac_enable_static_plugins="no")
 
 AC_ARG_ENABLE(ignoresigpipe,
               [  --enable-ignoresigpipe      Ignore SIGPIPE errors [[default=do not ignore]]],
-              ac_enable_ignoresigpipe="yes",
+              ac_enable_ignoresigpipe="$enableval",
               ac_enable_ignoresigpipe="no")
 
 AC_ARG_ENABLE(snmp,
               [  --disable-snmp              Disable SNMP support [[default=disable]]],
-              ac_disable_snmp="no",
+              ac_disable_snmp="$enableval",
               ac_disable_snmp="yes")
 
 AC_ARG_ENABLE(i18n,
               [  --enable-i18n               Enable (limited) internationalization [[default=disabled]]],
-              ac_enable_i18n="yes",
+              ac_enable_i18n="$enableval",
               ac_enable_i18n="no")
 
 AC_ARG_ENABLE(jumbo-frames,
               [  --enable-jumbo-frames       Enable Jumbo (9K) Ethernet frames [[default=disabled]]],
-              ac_enable_jumbo_frames="yes",
+              ac_enable_jumbo_frames="$enableval",
               ac_enable_jumbo_frames="no")
 
 AC_ARG_ENABLE(ipv6,
               [  --disable-ipv6              use IPv6 [[default=enabled]]],
-	      ac_disable_ipv6="yes",
-	      ac_disable_ipv6="no")        
+              ac_disable_ipv6="$enableval",
+              ac_disable_ipv6="no")
 
 dnl>
 dnl> Define the "WITH"s for package root directories ... deal with these later...
_______________________________________________
Ntop-dev mailing list
Ntop-dev@unipi.it
http://listgateway.unipi.it/mailman/listinfo/ntop-dev

Reply via email to