[EMAIL PROTECTED] wrote:
> Author: siren
> Date: Sun Mar 11 04:12:23 2007
> New Revision: 516888
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=516888
> Log:
> fix bin/nutch: line 152: cygpath: command not found on linux (FC5), hope i am 
> not breaking it for some other env
>
> Modified:
>     lucene/nutch/trunk/bin/nutch
>
> Modified: lucene/nutch/trunk/bin/nutch
> URL: 
> http://svn.apache.org/viewvc/lucene/nutch/trunk/bin/nutch?view=diff&rev=516888&r1=516887&r2=516888
> ==============================================================================
> --- lucene/nutch/trunk/bin/nutch (original)
> +++ lucene/nutch/trunk/bin/nutch Sun Mar 11 04:12:23 2007
> @@ -148,7 +148,7 @@
>    fi
>  fi
>  
> -if [ $cygwin -a "X${JAVA_LIBRARY_PATH}" != "X" ]; then
> +if $cygwin -a "X${JAVA_LIBRARY_PATH}" != "X"; then
>    JAVA_LIBRARY_PATH=`cygpath -p -w "$JAVA_LIBRARY_PATH"`
>  fi
>   


Again, this should have been discussed first.

How the code ended up in this place on Linux? The $cygwin condition 
should have prevented that, because it evaluates to true only on Cygwin, 
where this utility is required to translate the paths.

You also changed the "if" syntax - before it was using the /bin/test 
utility to evaluate the expression, now it uses a shell built-in  - I'm 
not sure if these two follow the same evaluation rules on all supported 
platforms ... Please revert it to the earlier syntax.

-- 
Best regards,
Andrzej Bialecki     <><
 ___. ___ ___ ___ _ _   __________________________________
[__ || __|__/|__||\/|  Information Retrieval, Semantic Web
___|||__||  \|  ||  |  Embedded Unix, System Integration
http://www.sigram.com  Contact: info at sigram dot com



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Nutch-developers mailing list
Nutch-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nutch-developers

Reply via email to