Hi Jun Yeah,I know your logic is right. It's just a compile warning that made me feel uncomfortable.
:) On 05/07/2018 08:52 AM, piaojun wrote: > Hi Larry, > > 'had_lock' will be initialized by ocfs2_inode_lock_tracker(), and the > 'bail' branch above won't use it either as 'inode_locked' is still zero. > > thanks, > Jun > > On 2018/5/6 17:49, Larry Chen wrote: >> The variable had_lock might be used uninitialized. >> >> Signed-off-by: Larry Chen <lc...@suse.com> >> --- >> fs/ocfs2/file.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c >> index 6ee94bc23f5b..50f17f56db36 100644 >> --- a/fs/ocfs2/file.c >> +++ b/fs/ocfs2/file.c >> @@ -1133,7 +1133,7 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr >> *attr) >> handle_t *handle = NULL; >> struct dquot *transfer_to[MAXQUOTAS] = { }; >> int qtype; >> - int had_lock; >> + int had_lock = 0; >> struct ocfs2_lock_holder oh; >> >> trace_ocfs2_setattr(inode, dentry, >> _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel