Hi Denis,
> > > - { "SendMessage", "ss", "", sms_send_message,
> > > + { "SendMessage", "ssb", "", sms_send_message,
> > >
> > > G_DBUS_METHOD_FLAG_ASYNC },
> > > { }
> > > };
> >
> > I don't like this being an argument to SendMessage(). I think it needs
> > to be exposed, but as a property instead. Is there a use case for
> > setting this per message? I think majority of current phones either
> > provide a global setting for this, or set it on by default.
> >
>
> I agree, we should expose this as the 'UseDeliveryReports' property on
> SmsManager or alternatively use a global oFono setting read at startup.
I think just a global setting in /etc/ofono/main.conf would be better. I
don't really see the point in making this an option for the user. My
personal opinion here is to always request delivery reports by default
and handle them internally to acknowledge SMS messages.
Regards
Marcel
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
