El dimecres, 17 de maig de 2023, a les 10:56:38 (CEST), Andre Heinecke va escriure: > Hi, > > On Tuesday 16 May 2023 23:55:00 CEST Albert Astals Cid wrote: > > The text looks reasonable to me, but i guess we'd definitely want some > > input from the KDE Promo folks. Want me to involve them or will you? > > I already did start on that yesterday. > https://marc.info/?l=kde-promo&m=168423425626159&w=2 > > Btw. my second mail in the thread gives some additional rationale why the > GnuPG integration is useful for us so it might be worth a read. > > > I can see that how that would make sense for translation but i don't see > > how this particular wording makes sense to be in the Okular repository. > > > > Imagine we get 10 different downstreams like you, we would need 10 > > different strings. > > > > One thing that comes to mind is we could come up with some kind of "these > > functionalities have been disabled" based on > > FORCE_NOT_REQUIRED_DEPENDENCIES have been set. (Or maybe just a generic > > one if any has been set?) > > I understand your point In Kleopatra we try to avoid that, too. > > What do you think about two options: > > option(OKULAR_UI_TITLE "Use an alternative title for the Okular UI. Please > consider when using FORCE_NOT_REQUIRED_DEPENDENCIES" "Okular") > option(SHOW_REDUCED_FUNCTIONALITY_WARNING "Show a warning on first run and > in the about dialog that this Okular comes with a reduced functionality > set." ((NOT FORCE_NOT_REQUIRED_DEPENDENCIES) AND (NOT > FORCE_NOT_REQUIRED_DEPENDENCIES STREQUAL ""))) > > That way we could have a generic warning because I don't think > our users will understand what the libraries mean and explaining that would > be too much. And a distro that might want to make only a minor change like > not shipping CHM support for some reason can set this option to "OFF" to > avoid such a warning. > > The reference to the Windows store should also be added with a > Q_OS_WIN ifdef and maybe for Linux with an "obtain from your Distribution". > > OKULAR_UI_TITLE we can then use to bring in "Okular (GnuPG Edition)". > > Probably best if I create an MR and we can discuss this there.
Yes. Cheers, Albert > > Best Regards, > Andre