Looks good (and youre fast!) I am not sure why you need to add stuff in configure instead of reusing ENABLE_GRAPHITE in the .scp file Too, but perhaps its too late here and I am tired ;).
Add a couple of lines to the NOTICE file (and fix my typo if you like) and its done. Thanks, this is pretty cool! Pedro. --- Gio 19/1/12, Ariel Constenla-Haile <arie...@apache.org> ha scritto: ... > -0800, Pedro Giffuni wrote: > > Hmm ... > > > > --- Gio 19/1/12, Ariel Constenla-Haile <arie...@apache.org> > ha scritto: > > ... > > > > > > I don't get the "force people" as long as we > already have > > > configure switches that set ENABLE_GRAPHITE and > WITH_FONTS > > > > > > > Yes but people should be warned and taking out all the > > fonts unless you enable graphite would be drastic. > > > > I guess we could condition the specific liberation > > font by adding || graphite checks in > > > > main/scp2/source/ooo/file_font_ooo.scp > > and > > main/more_fonts/fonts/ttf_libertine/makefile.mk > > > I guess this should be down following the WITHOUT_FONTS > define done in > configure.in, see attached patch. > > > Regards > -- > Ariel Constenla-Haile > La Plata, Argentina >
