Am Montag, den 09.08.2010, 13:52 -0500 schrieb Jason Kridner:
> Signed-off-by: Jason Kridner <jkrid...@beagleboard.org>

[…]

I know this has already been committed in
9eab7a12e4a94efbb53e5e43beeb67d15ae9eab5 [1].

But I do not like the commit summary. Is this script developed in a
repository somewhere else? Maybe put a link to the revision there.

> ---
>  recipes/angstrom/angstrom-uboot-scripts.bb         |    2 +-
>  .../beagleboard-validation-boot.cmd                |   15 +++++++--------
>  .../beagleboard-validation-user.cmd                |   15 +++++++--------
>  3 files changed, 15 insertions(+), 17 deletions(-)

[…]
 
> diff --git 
> a/recipes/angstrom/angstrom-uboot-scripts/beagleboard-validation-boot.cmd 
> b/recipes/angstrom/angstrom-uboot-scripts/beagleboard-validation-boot.cmd
> index 50a82a6..71d314c 100644
> --- a/recipes/angstrom/angstrom-uboot-scripts/beagleboard-validation-boot.cmd
> +++ b/recipes/angstrom/angstrom-uboot-scripts/beagleboard-validation-boot.cmd
> @@ -1,14 +1,13 @@
> -setenv dvimode 'hd720'
> -setenv vram '16M omapfb.vram=0:8M,1:4M,2:4M'
> +# On xM: bootargs=console=ttyS2,115200n8 mem=...@0x80000000 
> mem=3...@0x88000000 mpurate=1000 buddy=none camera=lbcm3m1 vram=16M 
> omapfb.vram=0:8M,1:4M,2:4M omapfb.mode=dvi:hd720 omapdss.def_disp=dvi 
> root=/dev/mmcblk0p2 rw rootfstype=ext3 rootwait
> +mmc init
> +setenv dvimode hd720
> +setenv vram 16M omapfb.vram=0:8M,1:4M,2:4M

Also a note would have been nice, why the »'« were removed.

[…]


Thanks,

Paul


[1] 
http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=9eab7a12e4a94efbb53e5e43beeb67d15ae9eab5

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Reply via email to