On Tue, Jul 09, 2013 at 02:58:03PM -0400, Joe MacDonald wrote: > [RE: [oe] [meta-networking][PATCH] dnsmasq: install .service only with > systemd in DISTRO_FEATURES] On 13.07.05 (Fri 07:45) Guo Chunrong-B40290 wrote: > > > Hello, Joe MacDonald > > New patch was submitted. > > I do not modify (atftp/tracker/gateone) recips and slim recipes do not > > work. > > SO the code in these recipes add ${systemd_unitdir} to FILES and these > > recipes work well. > > Just FYI, I saw your patch, I have it in a merge queue, but right now > I'm looking at the bug Paul quoted and the mailing list discussion > quoted therein to see if we can come up with a better, more general > solution.
FWIW: When I was moving systemd support from meta-systemd layer I was aware of this issue and I still believe that systemd.bbclass is right place to solve this, instead of adding conditionals in many recipes. Old systemd.bbclass in meta-systemd worked like this, maybe it wasn't most elegant solution, but it could be improved instead of pushing this issue to every recipes with .service file. Cheers, > > -----Original Message----- > > From: Joe MacDonald [mailto:joe.macdon...@windriver.com] > > Sent: Thursday, July 04, 2013 7:18 PM > > To: openembedded-devel@lists.openembedded.org > > Cc: Guo Chunrong-B40290; Yu Zongchun-B40527 > > Subject: Re: [oe] [meta-networking][PATCH] dnsmasq: install .service only > > with systemd in DISTRO_FEATURES > > > > [Re: [oe] [meta-networking][PATCH] dnsmasq: install .service only with > > systemd in DISTRO_FEATURES] On 13.07.04 (Thu 11:50) Paul Eggleton wrote: > > > > > On Thursday 04 July 2013 17:26:23 Chunrong Guo wrote: > > > > Signed-off-by: Chunrong Guo <b40...@freescale.com> > > > > --- > > > > .../recipes-support/dnsmasq/dnsmasq.inc | 8 +++++--- > > > > 1 files changed, 5 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/meta-networking/recipes-support/dnsmasq/dnsmasq.inc > > > > b/meta-networking/recipes-support/dnsmasq/dnsmasq.inc index > > > > 0f5b273..0710893 100644 > > > > --- a/meta-networking/recipes-support/dnsmasq/dnsmasq.inc > > > > +++ b/meta-networking/recipes-support/dnsmasq/dnsmasq.inc > > > > @@ -30,9 +30,11 @@ do_install () { > > > > install -d ${D}${sysconfdir}/ ${D}${sysconfdir}/init.d > > > > ${D}${sysconfdir}/dnsmasq.d install -m 644 ${WORKDIR}/dnsmasq.conf > > > > ${D}${sysconfdir}/ > > > > install -m 755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/dnsmasq > > > > - > > > > - install -d ${D}${systemd_unitdir}/system > > > > - install -m 0644 ${WORKDIR}/dnsmasq.service > > > > ${D}${systemd_unitdir}/system + > > > > + if > > > > + ${@base_contains('DISTRO_FEATURES','systemd','true','false',d)}; > > > > then + install -d ${D}${systemd_unitdir}/system > > > > + install -m 0644 ${WORKDIR}/dnsmasq.service > > > > ${D}${systemd_unitdir}/system + fi > > > > > > > > if [ "${@base_contains('PACKAGECONFIG', 'dbus', 'dbus', '', d)}" > > > > != "" > > > > ]; then install -d ${D}${sysconfdir}/dbus-1/system.d > > > > > > I think we should really have a global fix for this issue rather than > > > hacking up every recipe: > > > > > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=4309 > > > > I'm inclined to agree, but looking at the bug it looks like the potential > > solution was discussed in February and it's on the schedule for Yocto 1.5, > > but that's October. > > > > So I did a quick survey, here's the meta-networking recipes that'll be > > impacted, if we adopt the workaround approach: > > > > - net-snmp > > - dnsmasq (obviously) > > - ypbind-mt > > - yp-tools > > - ntp > > - atftp > > > > I decided I'd have a look at meta-oe for contrast (and guidance) and this > > is what I found there: > > > > - slim > > - tracker > > - cloud9 > > - zram > > - gpsd > > - gateone > > > > On the other hand, xinput-calibrator and xserver-nodm-init, already have > > the same fix in it Chunrong is proposing. So the impact of doing either > > isn't huge, but it's not small either. > > > > Chunrong: Would you be willing to retest and resubmit your patch with the > > above listed meta-networking recipes as a set? I don't see a lot of sense > > in doing this piecemeal, I'm okay with taking a workaround until > > #4309 gets fixed, but I'd rather tear the band-aid off all at once, so to > > speak. > > > > -- > > -Joe MacDonald. > > :wq > > > > -- > -Joe MacDonald. > :wq > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com
signature.asc
Description: Digital signature
_______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel