'entity' cannot be NULL here. This check caused false positive warning from Coverity.
Signed-off-by: Vaclav Dolezal <[email protected]> --- lib/control.c | 3 +-- lib/sensor.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/control.c b/lib/control.c index 64df4dac..346a6023 100644 --- a/lib/control.c +++ b/lib/control.c @@ -431,8 +431,7 @@ control_final_destroy(ipmi_control_t *control) if (control->waitq) opq_destroy(control->waitq); - if (control->entity) - ipmi_entity_remove_control(control->entity, control); + ipmi_entity_remove_control(control->entity, control); if (control->oem_info_cleanup_handler) control->oem_info_cleanup_handler(control, control->oem_info); diff --git a/lib/sensor.c b/lib/sensor.c index 96aef5f6..865fbb3b 100644 --- a/lib/sensor.c +++ b/lib/sensor.c @@ -1040,8 +1040,7 @@ sensor_final_destroy(ipmi_sensor_t *sensor) if (sensor->handler_list_cl) locked_list_destroy(sensor->handler_list_cl); - if (sensor->entity) - ipmi_entity_remove_sensor(sensor->entity, sensor); + ipmi_entity_remove_sensor(sensor->entity, sensor); if (sensor->oem_info_cleanup_handler) sensor->oem_info_cleanup_handler(sensor, sensor->oem_info); -- 2.20.1 _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
