On Sat, Feb 25, 2023 at 09:39:46PM -0800, Randy Dunlap wrote: > REGMAP is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change the use of "depends on REGMAP_MMIO" to > "select REGMAP_MMIO", which will also set REGMAP.
This seems reasonable. I can take it into my tree, or.. Acked-by: Corey Minyard <[email protected]> > > Fixes: eb994594bc22 ("ipmi: bt-bmc: Use a regmap for register access") > Signed-off-by: Randy Dunlap <[email protected]> > Cc: Andrew Jeffery <[email protected]> > Cc: Corey Minyard <[email protected]> > Cc: [email protected] > Cc: Arnd Bergmann <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > --- > drivers/char/ipmi/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff -- a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig > --- a/drivers/char/ipmi/Kconfig > +++ b/drivers/char/ipmi/Kconfig > @@ -162,7 +162,8 @@ config IPMI_KCS_BMC_SERIO > > config ASPEED_BT_IPMI_BMC > depends on ARCH_ASPEED || COMPILE_TEST > - depends on REGMAP && REGMAP_MMIO && MFD_SYSCON > + depends on MFD_SYSCON > + select REGMAP_MMIO > tristate "BT IPMI bmc driver" > help > Provides a driver for the BT (Block Transfer) IPMI interface _______________________________________________ Openipmi-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openipmi-developer
