On Wed, 21 Apr 2021 13:45:57 GMT, Johan Vos <[email protected]> wrote:
> Hide accumCell when the cell is released. > Fix for JDK-8265669 The change as such is fine, but, I have two questions at a higher level - > (from JBS description) - "This will lead to a call to Cell.updateItem(). That > was already happening before, but it is happening more often now in case the > gradual caching goes faster than the scrolling. " Question - 1) How did you find out it is happening more often? Do you have any test that you feel is worth adding? > (from JBS bug description) - "In order to allow this logic to still be > possible, I suggest the accumCell should always made be invisble after it has > done its work. That way, the `updateItem` can clearly decide what to do, > based on not only the index, but also the visibility of the considered item. " Question - 2) Does this mean any followup work is needed to tweak `updateItem` after this change ? ------------- PR: https://git.openjdk.java.net/jfx/pull/474
