On Wed, 4 May 2022 16:55:30 GMT, Jose Pereda <jper...@openjdk.org> wrote:

>> This PR updates the screen for each window even for the case where the old 
>> screen has been disposed but there is a new screen instance found for such 
>> window.
>> 
>> This is the case of Android, where the lifecycle of the application allows 
>> destroying the native screen when the app goes to the background, and 
>> providing a new native screen, in case it comes back to the foreground. 
>> Before this PR, the screen for the window wasn't updated after returning 
>> from the background, and if orientation changes happened, the dimensions 
>> were wrong.
>
> Jose Pereda has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Scale screen dimensions

modules/javafx.graphics/src/main/native-glass/monocle/android/nativeBridge.c 
line 171:

> 169:         0, 0, (jint) width, (jint) height,
> 170:         0, 0, (jint) width, (jint) height,
> 171:         100, 100, (jfloat) 1, (jfloat) 1, androidDensity, 
> androidDensity);

might be good to replace the `100` with e.g. `dpi` and assign a constant value 
(100) at the top of this file to it, in case we later want to retrieve that in 
a more dynamic way.

-------------

PR: https://git.openjdk.java.net/jfx/pull/778

Reply via email to