On Tue, 24 May 2022 14:54:19 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Adding JGObject in plave of raw jni object
>
> modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp
>  line 99:
> 
>> 97: }
>> 98: 
>> 99: void EventListenerManager::resetDOMWindow(DOMWindow* window)
> 
> Have you validated this logic? If I understand correctly, the 
> `isReferringToOtherListener` var will be true if any listener in the list of 
> listeners for this DOM window has a ref count > 1. Is my understanding 
> correct? This doesn't seem quite right to me, but I may be missing something.

yes , this is the case where we would remove pairs from map.

-------------

PR: https://git.openjdk.java.net/jfx/pull/799

Reply via email to